Dry up Settings from Map Construction #61778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the same hack all over the place. At least drying it up to a single place.
original-brownbear
added
>non-issue
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Settings) |
jaymode
approved these changes
Sep 1, 2020
Member
jaymode
left a comment
jaymode
left a comment
There was a problem hiding this comment.
Left one comment to close the builder. LGTM.
server/src/main/java/org/elasticsearch/common/settings/Settings.java
Outdated
Show resolved
Hide resolved
…s.java Co-authored-by: Jay Modi <[email protected]>
Contributor
Author
|
Thanks Jay! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 1, 2020
We used the same hack all over the place. At least drying it up to a single place. Co-authored-by: Jay Modi <[email protected]>
original-brownbear
added a commit
that referenced
this pull request
Sep 1, 2020
We used the same hack all over the place. At least drying it up to a single place. Co-authored-by: Jay Modi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while adding a new REST endpoint that has settings in the body:
We used the same hack all over the place => at least drying it up to a single place.