Implement deprecation logging using log4j #61629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of elastic#61474. Part of elastic#46106. Simplify the implementation of deprecation logging by relying of log4j more completely, and implementing additional behaviour through custom appenders and filters.
pugnascotia
added
:Core/Infra/Logging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
Contributor
Author
|
@pgomulka this backport was straightforward after your backports, but I'd still feel happier if you'd take a quick too over this 🙏 |
pgomulka
approved these changes
Aug 31, 2020
| return new DeprecationLoggerBuilder().withDeprecation(key, msg, params); | ||
| } | ||
|
|
||
| public class DeprecationLoggerBuilder { |
Contributor
There was a problem hiding this comment.
I wonder if we need this builder in 7.x - I removed this from my backport because there will be no compatible logger in 7.x
However I am thinking now that it might cause problems for future backports and we should keep it?
WDYT?
Contributor
Author
There was a problem hiding this comment.
Let's keep it - we've already backported more logging changes to 7.x than we expected, and there may well be more before v8 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61474.
Part of #46106. Simplify the implementation of deprecation logging by
relying of log4j more completely, and implementing additional behaviour
through custom appenders and filters.