Support point in time in async search #61560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
approved these changes
Aug 26, 2020
| return List.of(new Route(POST, "/{index}/_pit")); | ||
| return List.of( | ||
| new Route(POST, "/{index}/_pit"), | ||
| new Route(POST, "/_pit")); |
Contributor
There was a problem hiding this comment.
Maybe we should disable creating a _pit for all indices ?
Member
Author
@jimczi Thank you for your review. I am merging this PR to unblock the work in ccs. I will discuss it with you tomorrow. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 10, 2020
This commit integrates point in time into async search and ensures that it works correctly with security enabled. Relates elastic#61062
dnhatn
added a commit
that referenced
this pull request
Sep 10, 2020
This commit integrates point in time into async search and ensures that it works correctly with security enabled. Relates #61062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit integrates point in time into async search and ensures that it works correctly with security enabled.
Relates #61062