Skip to content

[DOCS] Fix old NodeSelector field in Low Level REST Client #61551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

[DOCS] Fix old NodeSelector field in Low Level REST Client #61551

merged 1 commit into from
Aug 31, 2020

Conversation

@matsumana
Copy link
Contributor

@matsumana matsumana commented Aug 25, 2020

@jtibshirani jtibshirani added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >docs General docs changes labels Aug 25, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 25, 2020

Pinging @elastic/es-core-features (:Core/Features/Java Low Level REST Client)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 25, 2020

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Aug 25, 2020
@matsumana
Copy link
Contributor Author

matsumana commented Aug 29, 2020

Could you review this please?

jrodewig
jrodewig approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @matsumana.

@jrodewig
Copy link
Contributor

jrodewig commented Aug 31, 2020

@elasticmachine test this please

@jrodewig jrodewig merged commit bf95503 into elastic:master Aug 31, 2020
This was referenced Aug 31, 2020
Merged
Merged
jrodewig added a commit that referenced this pull request Aug 31, 2020
@jrodewig @matsumana
[DOCS] Fix old NodeSelector field in Low Level REST Client (#61551) (#…
054a64d 
…61718)

Co-authored-by: Manabu Matsuzaki <[email protected]>
jrodewig added a commit that referenced this pull request Aug 31, 2020
@jrodewig @matsumana
[DOCS] Fix old NodeSelector field in Low Level REST Client (#61551) (#…
21cb50f 
…61719)

Co-authored-by: Manabu Matsuzaki <[email protected]>
@matsumana
Copy link
Contributor Author

matsumana commented Aug 31, 2020

Thanks!

@matsumana matsumana deleted the fix/doc-for-node-selector branch August 31, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matsumana @elasticmachine @jrodewig @jtibshirani