Skip to content

Conversation

@benwtrent
Copy link
Member

This is a minor refactor where the job node load logic (node availability, etc.) is refactored into its own class.

This will allow future things (i.e. autoscaling decisions) to use the same node load detection class.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent requested a review from przemekwitek August 27, 2020 12:48
…NodeLoadDetector.java

Co-authored-by: Przemysław Witek <[email protected]>
@benwtrent
Copy link
Member Author

@elasticmachine update branch

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 0501bfd into elastic:master Aug 27, 2020
@benwtrent benwtrent deleted the feature/ml-job-node-selector-refactor branch August 27, 2020 17:22
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Aug 31, 2020
This is a minor refactor where the job node load logic (node availability, etc.) is refactored into its own class.

This will allow future things (i.e. autoscaling decisions) to use the same node load detection class.
benwtrent added a commit that referenced this pull request Aug 31, 2020
This is a minor refactor where the job node load logic (node availability, etc.) is refactored into its own class.

This will allow future things (i.e. autoscaling decisions) to use the same node load detection class.
backport of #61521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants