[Backport 7.9][API keys] Add full_name and email to API key doc and use them to populate authing User (#61354) #61404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydmeta
added
:Security/Authentication
lloydmeta
force-pushed
the
backport-7.9-security/API-keys-add-full_name-email-to-doc
branch
from
da7550c to
4c7a227
Compare
…se them to populate authing User (elastic#61354) The API key document currently doesn't include the user's full_name or email attributes, and as a result, when those attributes return `null` when hitting `GET`ing `/_security/_authenticate`, and in the SAML response from the [IdP Plugin](elastic#54046). This changeset adds those fields to the document and extracts them to fill in the User when authenticating. They're effectively going to be a snapshot of the User from when the key was created, but this is in line with roles and metadata as well. Signed-off-by: lloydmeta <[email protected]>
lloydmeta
force-pushed
the
backport-7.9-security/API-keys-add-full_name-email-to-doc
branch
from
4c7a227 to
51d1ff4
Compare
Collaborator
|
Pinging @elastic/es-security (:Security/Authentication) |
lloydmeta
deleted the
backport-7.9-security/API-keys-add-full_name-email-to-doc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61354 to 7.9 branch
The API key document currently doesn't include the user's full_name or email attributes,
and as a result, when those attributes return
nullwhen hittingGETing/_security/_authenticate,and in the SAML response from the IdP Plugin.
This changeset adds those fields to the document and extracts them to fill in the User when
authenticating. They're effectively going to be a snapshot of the User from when the key was
created, but this is in line with roles and metadata as well.