Opt date valued script fields out of rate limit #61238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
the
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
This excuses script fields from the script compilation rate limiting. It'd be fairly sad to prevent mapping updates because of the rate limit. And we don't expect folks to add a zillion fields. On the other hand, once we allow these scripts on the `_search` request we might indeed want them to be considered in the limit. But we don't support that yet and we can deal with that when we get there.
nik9000
commented
Aug 17, 2020
|
|
||
| public abstract class DateScriptFieldScript extends AbstractLongScriptFieldScript { | ||
| public static final ScriptContext<Factory> CONTEXT = new ScriptContext<>("date_script_field", Factory.class); | ||
| public static final ScriptContext<Factory> CONTEXT = newContext("date", Factory.class); |
Member
Author
There was a problem hiding this comment.
I've only done this to a single script field. If we like it I'd be happy to do it in a follow up.
30 tasks
Member
|
@stu-elastic @jdconrad can either of you have a look too, please? Thanks! |
javanna
approved these changes
Aug 18, 2020
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM I asked the painless folks to also have a look, just to make sure that we are all on the same page.
Member
Author
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excuses script fields from the script compilation rate limiting.
It'd be fairly sad to prevent mapping updates because of the rate limit.
And we don't expect folks to add a zillion fields. On the other hand,
once we allow these scripts on the
_searchrequest we might indeedwant them to be considered in the limit. But we don't support that yet
and we can deal with that when we get there.