Deprecate and ignore join timeout #60872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in timing out a join attempt any more once a cluster is entirely in 7.x. Timing out and retrying with the same master is pointless, and an in-flight join attempt to one master no longer blocks attempts to join other masters. This commit deprecates this unnecessary setting and removes its effect from the joining process.
DaveCTurner
added
>enhancement
>deprecation
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
elasticmachine
added
the
Team:Distributed (Obsolete)
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 10, 2020
There is no point in timing out a join attempt any more. Timing out and retrying with the same master is pointless, and an in-flight join attempt to one master no longer blocks attempts to join other masters. This commit removes this unnecessary setting. Relates elastic#60872 in which this setting was deprecated.
Merged
Contributor
Author
|
NB this PR is against |
DaveCTurner
commented
Aug 10, 2020
| public static final String VALIDATE_JOIN_ACTION_NAME = "internal:cluster/coordination/join/validate"; | ||
| public static final String START_JOIN_ACTION_NAME = "internal:cluster/coordination/start_join"; | ||
|
|
||
| // the timeout for each join attempt |
Contributor
Author
There was a problem hiding this comment.
We probably don't need this for Zen1 joining too, although there's some complexity with the process of bootstrapping the cluster during a rolling upgrade. Rather than spend any time on the analysis I decided to leave the behaviour in mixed-version clusters alone.
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/1 (looks like a transient (?) Gradle (?) issue) |
DaveCTurner
added a commit
that referenced
this pull request
Aug 10, 2020
There is no point in timing out a join attempt any more. Timing out and retrying with the same master is pointless, and an in-flight join attempt to one master no longer blocks attempts to join other masters. This commit removes this unnecessary setting. Relates #60872 in which this setting was deprecated.
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in timing out a join attempt any more once a cluster
is entirely in 7.x. Timing out and retrying with the same master is
pointless, and an in-flight join attempt to one master no longer blocks
attempts to join other masters. This commit deprecates this unnecessary
setting and removes its effect from the joining process.
Relates #60873 which removes this setting in
master.