Unify Stream Copy Buffer Usage (#56078) #60608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have various ways of copying between two streams and handling thread-local buffers throughout the codebase. This commit unifies a number of them and removes buffer allocations in many spots.
original-brownbear
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Contributor
Author
|
Jenkins run elasticsearch-ci/default-distro |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 4, 2020
In elastic#60608 we missed aligning the Java11 version of this class and this is breaking BwC tests now. This commit aligns Java11 and Java8 versions of it again.
original-brownbear
added a commit
that referenced
this pull request
Aug 4, 2020
In #60608 we missed aligning the Java11 version of this class and this is breaking BwC tests now. This commit aligns Java11 and Java8 versions of it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have various ways of copying between two streams and handling thread-local
buffers throughout the codebase. This commit unifies a number of them and
removes buffer allocations in many spots.
backport of #56078