Skip to content

[Transform] implement test suite to test continuous transforms #60469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2020
Merged

[Transform] implement test suite to test continuous transforms #60469

merged 3 commits into from
Aug 5, 2020

Conversation

@hendrikmuhs
Copy link

@hendrikmuhs hendrikmuhs commented Jul 30, 2020 •
edited
Loading

implements a test suite for testing continuous transform with randomization in terms of mappings, index
settings, transform configuration. Add a test case for terms and date histogram.
The test covers:

  • continuous mode with several checkpoints created
  • correctness of results
  • optimizations (minimal necessary writes)
  • permutations of features (index settings, aggs, data types, index or data stream)

@hendrikmuhs hendrikmuhs added >test Issues or PRs that are addressing/adding tests v8.0.0 :ml/Transform Transform v7.10.0 labels Jul 30, 2020
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Aug 3, 2020
fixes mix up of input and output field name for date histogram optimi…
080c9ad 
…zation.

minimal fix, more tests to be added with elastic#60469

fixes elastic#60590
@hendrikmuhs hendrikmuhs mentioned this pull request Aug 3, 2020
Merged
hendrikmuhs pushed a commit that referenced this pull request Aug 3, 2020
[Transform] fix regression of date histogram optimization (#60591)
783771a 
fixes mix up of input and output field name for date histogram optimization.

minimal fix, more tests to be added with #60469

fixes #60590
hendrikmuhs pushed a commit that referenced this pull request Aug 3, 2020
[Transform] fix regression of date histogram optimization (#60591)
cd6492f 
fixes mix up of input and output field name for date histogram optimization.

minimal fix, more tests to be added with #60469

fixes #60590
@hendrikmuhs hendrikmuhs force-pushed the transform-continuous-testing-2 branch 2 times, most recently from db116e7 to 07f725f Compare August 3, 2020 14:55
hendrikmuhs
hendrikmuhs commented Aug 3, 2020
View reviewed changes
.../rest-high-level/src/main/java/org/elasticsearch/client/transform/transforms/DestConfig.java Outdated
Copy link
Author

@hendrikmuhs hendrikmuhs Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ that's the only change: making the constructor public

@hendrikmuhs hendrikmuhs marked this pull request as ready for review August 4, 2020 06:42
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 4, 2020

Pinging @elastic/ml-core (:ml/Transform)

@benwtrent benwtrent self-requested a review August 4, 2020 12:05
@hendrikmuhs hendrikmuhs force-pushed the transform-continuous-testing-2 branch from 84731fd to 03c8d83 Compare August 5, 2020 08:47
@hendrikmuhs hendrikmuhs merged commit 9b2e690 into elastic:master Aug 5, 2020
@hendrikmuhs hendrikmuhs deleted the transform-continuous-testing-2 branch August 5, 2020 09:38
This was referenced Aug 5, 2020
Merged
Closed
@hendrikmuhs hendrikmuhs mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees

No one assigned

Labels

:ml/Transform Transform >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hendrikmuhs @elasticmachine @benwtrent @jakelandis