Fix Snapshot Status API Docs Test #59902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clock resolution for this API is our default 200ms. It is unlikely but possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test. Just matching the fact taht we get an integer here for the time taken should be enough in this test.
original-brownbear
added
>docs
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
elasticmachine
added
Team:Distributed (Obsolete)
Contributor
Author
|
Thanks Nik! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 20, 2020
The clock resolution for this API is our default 200ms. It is unlikely but possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test. Just allowing any value here seems fine to me (seems we can't match for integer specifically).
original-brownbear
added a commit
that referenced
this pull request
Jul 20, 2020
The clock resolution for this API is our default 200ms. It is unlikely but possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test. Just allowing any value here seems fine to me (seems we can't match for integer specifically).
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 23, 2020
The clock resolution for this API is our default 200ms. It is unlikely but possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test. Just allowing any value here seems fine to me (seems we can't match for integer specifically).
original-brownbear
added a commit
that referenced
this pull request
Jul 23, 2020
The clock resolution for this API is our default 200ms. It is unlikely but possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test. Just allowing any value here seems fine to me (seems we can't match for integer specifically).
jrodewig
added a commit
that referenced
this pull request
Jul 28, 2020
The clock resolution for this API is our default 200ms. It is unlikely but possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test. Just allowing any value here seems fine to me (seems we can't match for integer specifically). Co-authored-by: Armin Braun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clock resolution for this API is our default 200ms. It is unlikely but
possible that a shard snapshot starts and ends on separate clock ticks and that breaks the test.
Just allowing any value here seems fine to me (seems we can't match for integer specifically).