Fix Snapshot Status API Docs Test #59775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't just assume a fixed number for the overall file count. Depending on how the merging/flushing works out we won't always have 4 files for the index across all versions, systems etc. Also, we could have x-pack concurrently create some system indices which could mess up the total numbers here. Fixed by only snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Closes elastic#59767
original-brownbear
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
Team:Distributed (Obsolete)
jrodewig
approved these changes
Jul 17, 2020
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
👍 LGTM.
Thanks for fixing. I hadn't considered that this stat may not be predictable.
lockewritesdocs
approved these changes
Jul 17, 2020
Contributor
lockewritesdocs
left a comment
lockewritesdocs
left a comment
There was a problem hiding this comment.
@original-brownbear, thank you for fixing this issue! It took some iterating with @jrodewig to fix the original test cases. The tests passed the CI checks, so I'm curious why it's now causing errors. I'll backport this change after it's merged.
Contributor
Author
|
Thanks @jrodewig @lockewritesdocs !
Thanks, then I won't backport here and leave it to you :) |
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Jul 17, 2020
We can't just assume a fixed number for the overall file count. Depending on how the merging/flushing works out we won't always have 4 files for the index across all versions, systems etc. Also, we could have x-pack concurrently create some system indices which could mess up the total numbers here. Fixed by only snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Closes elastic#59767
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Jul 17, 2020
We can't just assume a fixed number for the overall file count. Depending on how the merging/flushing works out we won't always have 4 files for the index across all versions, systems etc. Also, we could have x-pack concurrently create some system indices which could mess up the total numbers here. Fixed by only snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Closes elastic#59767
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Jul 17, 2020
We can't just assume a fixed number for the overall file count. Depending on how the merging/flushing works out we won't always have 4 files for the index across all versions, systems etc. Also, we could have x-pack concurrently create some system indices which could mess up the total numbers here. Fixed by only snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Closes elastic#59767
lockewritesdocs
pushed a commit
that referenced
this pull request
Jul 17, 2020
Introduce a fix to tests by snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Co-authored-by: Armin Braun <[email protected]>
lockewritesdocs
pushed a commit
that referenced
this pull request
Jul 17, 2020
Introduce a fix to tests by snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Co-authored-by: Armin Braun <[email protected]>
lockewritesdocs
pushed a commit
that referenced
this pull request
Jul 17, 2020
Introduce a fix to tests by snapshotting a single index+shard in the snapshot that we get the status for and verifying consistency instead of equality for total file counts. Co-authored-by: Armin Braun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't just assume a fixed number for the overall file count.
Depending on how the merging/flushing works out we won't always have
4 files for the index across all versions, systems etc.
Also, we could have x-pack concurrently create some system indices
which could mess up the total numbers here.
Fixed by only snapshotting a single index+shard in the snapshot that
we get the status for and verifying consistency instead of equality
for total file counts.
Closes #59767
Backports: