Scripting: fix generateContextDoc path and url #59676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add doc runtime class path * Use `getHttpSocketURI` instead of `getAllHttpSocketURI` to get a single test cluster URL rather than a list
stu-elastic
added
>bug
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
Collaborator
|
Pinging @elastic/es-docs (:Docs) |
jdconrad
requested changes
Jul 15, 2020
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
Please take a look at ContextDocGenerator.isInternalClass and add exclusions for the new internal classes for query langs like EQL.
docs/painless/painless-api-reference/painless-api-reference-string-sort/packages.asciidoc
Outdated
Show resolved
Hide resolved
docs/painless/painless-api-reference/painless-api-reference-string-sort/packages.asciidoc
Outdated
Show resolved
Hide resolved
docs/painless/painless-api-reference/painless-api-reference-shared/packages.asciidoc
Outdated
Show resolved
Hide resolved
docs/painless/painless-api-reference/painless-api-reference-number-sort/packages.asciidoc
Outdated
Show resolved
Hide resolved
…nternalQlScriptUtils, ScoreScript.ExplanationHolder
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Jul 16, 2020
* Add doc runtime class path * Use getAllHttpSocketURI.get(0) instead of getAllHttpSocketURI to get a single test cluster URL rather than a list Backport: 3057e0f
stu-elastic
added a commit
that referenced
this pull request
Jul 16, 2020
Contributor
Author
|
master: 3057e0f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getAllHttpSocketURI.get(0)instead ofgetAllHttpSocketURIto get a singletest cluster URL rather than a list