Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 15, 2020

Eclipse was confused by #59583. It can't see a the public inner
interface within the superclass. This time. Usually that is fine, but
the Eclipse gods don't like this particular code, I guess.

Eclipse was confused by elastic#59583. It can't see a the public inner
interface within the superclass. This time. Usually that is fine, but
the Eclipse gods don't like this particular code, I guess.
@nik9000 nik9000 added >non-issue :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.9.0 labels Jul 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 15, 2020
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nik9000 for fixing this. It looks okay to me, although it's not clear to me how #59583 caused this to start failing.

@nik9000 nik9000 added v7.10.0 and removed v7.9.0 labels Jul 15, 2020
@nik9000
Copy link
Member Author

nik9000 commented Jul 15, 2020

run elasticsearch-ci/2

@nik9000 nik9000 merged commit 678ae31 into elastic:master Jul 15, 2020
@nik9000
Copy link
Member Author

nik9000 commented Jul 15, 2020

Thanks @jtibshirani! I pushed a change that adds a link to the Eclipse bug I filed with a reproduction.

nik9000 added a commit that referenced this pull request Jul 16, 2020
Eclipse was confused by #59583. It can't see a the public inner
interface within the superclass. This time. Usually that is fine, but
the Eclipse gods don't like this particular code, I guess.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.10.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants