Skip to content

Conversation

@jtibshirani
Copy link
Contributor

This change clarifies the order in which components are merged. It also adds
information on mapping merging, now that this has been implemented.

This change clarifies the order in which components are merged. It also adds
information on mapping merging, now that this has been implemented.
@jtibshirani jtibshirani added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.9.0 labels Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jtibshirani jtibshirani force-pushed the template-mapping-docs branch from 54ad0dc to 640d92b Compare July 13, 2020 20:58
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 13, 2020
@jtibshirani jtibshirani requested review from dakrone and jrodewig July 13, 2020 21:46
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Julie!

In this case, an index matching `t*` will have three primary shards. If the order of composed
templates were reversed, the index would have two primary shards.

Mapping definitions are merged recursively, which means that later mapping components can
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add examples here because there are many different behaviors at play and it would require a lot of space. I figured that users could call the 'simulate API' to test out individual questions they had.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jtibshirani jtibshirani merged commit 0e15cc5 into elastic:master Jul 14, 2020
@jtibshirani jtibshirani deleted the template-mapping-docs branch July 14, 2020 18:07
@jtibshirani
Copy link
Contributor Author

Thanks for the reviews.

jtibshirani added a commit that referenced this pull request Jul 14, 2020
This change clarifies the order in which components are merged. It also adds
information on mapping merging, now that this has been implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team Team:Search Meta label for search team v7.9.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants