-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Even more robust API key auth 429 test #59159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
2 similar comments
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
Collaborator
|
Pinging @elastic/es-security (:Security/Authentication) |
Member
Author
|
@tvernum The tests have been successfully for 5 consecutive runs. It should be good for review. Thanks! |
tvernum
approved these changes
Jul 8, 2020
Contributor
tvernum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 8, 2020
Ensure blocking tasks are running before submitting more no-op tasks. This ensures no task would be popped out of the queue unexpectedly, which in turn guarantees the rejection of subsequent authentication request.
ywangd
added a commit
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
>test
Issues or PRs that are addressing/adding tests
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @tvernum, the new
SocketTimeoutExceptionis likely due to the authenticate request being put onto the queue instead of the expected rejection. Since the thread pool is intentionally blocked, the authenticate request fails to come back in time.Here are what likely happend in time order:
EsRejectedExecutionExceptionfailure (Make test more robust for API key auth 429 #59077).So the fix is to ensure that authentication request in step 5 does not get put onto the queue. This can be ahieved by ensuring all blocking tasks from step 2 are alreadying running before move onto step 3. Once active threads are indeed blocked, we can then be sure that no tasks would be popped out of the queue unexpectedly, which in turn guarantees the rejection of the subsequent authentication request.
Resolves: #59149