Inline no-op IndicesModule#getEngineFactories #59051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was introduced in elastic#31183 but it has no effect and is never overridden so this commit removes it.
DaveCTurner
added
>non-issue
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
elasticmachine
added
the
Team:Distributed (Obsolete)
jasontedor
reviewed
Jul 6, 2020
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
The intention was to follow our typical model in plugins which is that core could provide some implementations, and plugins can provide some implementations. No problem removing this though, only explaining the intention. Note that there's a comment on line 440 of Node.java that can be removed as a result of making this change.
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/1 |
DaveCTurner
deleted the
2020-07-06-remove-IndicesModule#getEngineFactories
branch
DaveCTurner
added a commit
that referenced
this pull request
Jul 7, 2020
This method was introduced in #31183 but it has no effect and is never overridden so this commit removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was introduced in #31183 but it has no effect and is never
overridden so this commit removes it.