EQL: Obey size request parameter #59014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While at it, change the default size to 10 (to align it with the search API defaults).
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
astefan
reviewed
Jul 3, 2020
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM.
I think we should also update the HLRC default for size: https://github.com/elastic/elasticsearch/blob/master/client/rest-high-level/src/main/java/org/elasticsearch/client/eql/EqlSearchRequest.java#L46
Member
Author
|
Thanks - I'll follow-up with a different PR that touches the request to introduce the notion of fetch size (that is how big the page is when looking for join/sequences). |
costin
added a commit
that referenced
this pull request
Jul 4, 2020
UnresolvedRelation does not care about its source during equality hence ignore it when doing randomized mutations. Relates #59014
costin
added a commit
that referenced
this pull request
Jul 6, 2020
While at it, change the default size to 10 (to align it with the search API defaults). (cherry picked from commit 4579593)
This was referenced Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass default size through a dedicated head/tail added at parsing.
While at it, change the default size to 10 (to align it with the search
API defaults).