Default gateway.auto_import_dangling_indices to false #58898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of elastic#48366. Now that there is a dedicated API for dangling indices, the auto-import behaviour can default to off.
pugnascotia
added
>enhancement
>breaking
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
DaveCTurner
reviewed
Jul 9, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Code changes LGTM, but I think this needs an entry in the breaking changes docs too.
DaveCTurner
approved these changes
Jul 9, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Oh wait, the breaking changes docs for 7.9 don't exist in master so this LGTM for 8.0 and the docs can be added for the back port.
Contributor
Author
|
@DaveCTurner Thanks for the reminder about the breaking changes doc 👍 |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Jul 15, 2020
Part of elastic#48366. Now that there is a dedicated API for dangling indices, the auto-import behaviour can default to off.
pugnascotia
added a commit
that referenced
this pull request
Jul 15, 2020
pugnascotia
added a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #48366. Now that there is a dedicated API for dangling indices,
the auto-import behaviour can default to off.
Docs will be updated in #58751.