Skip to content

[7.x] [ML] handles compressed model stream from native process (#58009) #58836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2020
Merged

[7.x] [ML] handles compressed model stream from native process (#58009) #58836

merged 5 commits into from
Jul 1, 2020

Conversation

@benwtrent
Copy link
Member

@benwtrent benwtrent commented Jul 1, 2020

Backports the following commits to 7.x:

@benwtrent
[ML] handles compressed model stream from native process (elastic#58009)
ed15020 
This moves model storage from handling the fully parsed JSON string to handling two separate types of documents.

1. ModelSizeInfo which contains model size information 
2. TrainedModelDefinitionChunk which contains a particular chunk of the compressed model definition string.

`model_size_info` is assumed to be handled first. This will generate the model_id and store the initial trained model config object. Then each chunk is assumed to be in correct order for concatenating the chunks to get a compressed definition.


Native side change: elastic/ml-cpp#1349
@benwtrent benwtrent added :ml Machine learning backport labels Jul 1, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 1, 2020

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Member Author

benwtrent commented Jul 1, 2020

run elasticsearch-ci/2

@benwtrent
Copy link
Member Author

benwtrent commented Jul 1, 2020

run elasticsearch-ci/2

@benwtrent
Copy link
Member Author

benwtrent commented Jul 1, 2020

@elasticmachine update branch

@benwtrent
Copy link
Member Author

benwtrent commented Jul 1, 2020

@elasticmachine update branch

@benwtrent
Copy link
Member Author

benwtrent commented Jul 1, 2020

jenkins retest this please

@benwtrent
Copy link
Member Author

benwtrent commented Jul 1, 2020

@elasticmachine update branch

@benwtrent benwtrent merged commit c64e283 into elastic:7.x Jul 1, 2020
@benwtrent benwtrent deleted the backport/7.x/pr-58009 branch October 19, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport :ml Machine learning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benwtrent @elasticmachine