Skip over metadata fields in the field retrieval API. #58710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
jtibshirani
force-pushed
the
field-retrieval
branch
from
2a15f6c to
476e454
Compare
jtibshirani
force-pushed
the
fetch-meta-fields
branch
from
2cf254f to
c8b5a95
Compare
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
force-pushed
the
fetch-meta-fields
branch
from
c8b5a95 to
037e4e1
Compare
nik9000
approved these changes
Jun 30, 2020
jtibshirani
added a commit
that referenced
this pull request
Jun 30, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
that referenced
this pull request
Jul 8, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
that referenced
this pull request
Jul 14, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
that referenced
this pull request
Jul 15, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
that referenced
this pull request
Jul 18, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
that referenced
this pull request
Jul 21, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
that referenced
this pull request
Jul 23, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Jul 27, 2020
This avoids unnecessary lookups, since metadata fields don't have _source values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary lookups, since metadata fields don't have _source
values. Plus, many of them already come back as top-level fields in the search
response, such as
_id,_index,_routing, etc.In the future we can consider support for metadata fields like
_size, thatmust be explicitly retrieved but whose values aren't stored in the document
source.