HLRC: UpdateByQuery API with wait_for_completion being false #58552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
elasticmachine
added
the
Team:Data Management
Contributor
|
@elasticmachine ok to test |
Contributor
|
@tumile Thank you for the contribution and sorry it took us so long to get to this. This generally looks very good 🎉 Would you mind merging master into your branch and fixing the conflict? |
Contributor
Author
|
I'm on it 🙌 |
Contributor
Author
|
@andreidan ready for review |
andreidan
approved these changes
Aug 13, 2020
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Aug 13, 2020
…#58552) (cherry picked from commit 291f5bd) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Aug 13, 2020
…#61081) (cherry picked from commit 291f5bd) Signed-off-by: Andrei Dan <[email protected]> Co-authored-by: Tuan Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend support for wait_for_completion=false to UpdateByQuery API by adding
submitUpdateByQueryTask. Similar to prior art #35202.Closes: #46350.