EQL: Fix race condition in RestEqlCancellationIT #58493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes RestEqlCancellationIT more deterministic by adding an assertBusy for the cancellation propagation. It also refactors the SearchBlockPlugin to block after the field caps are received, which prevents the test to block on the transport thread. Blocking on transport thread was preventing the cancellation on disconnect from cancelling the task until after the block on the transport thread was released. Since I cannot reporduce this issue, I will leave the trace logging for now and will remove it after observing this test for a while in CI. Relates to elastic#58270
imotov
added
>test-failure
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jun 25, 2020
Makes RestEqlCancellationIT more deterministic by adding an assertBusy for the cancellation propagation. It also refactors the SearchBlockPlugin to block after the field caps are received, which prevents the test to block on the transport thread. Blocking on transport thread was preventing the cancellation on disconnect from cancelling the task until after the block on the transport thread was released. Since I cannot reporduce this issue, I will leave the trace logging for now and will remove it after observing this test for a while in CI. Relates to elastic#58270
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jun 29, 2020
The test didn't fail since the fix in elastic#58493. So, it's time to remove debug logging and close the issue. Closes elastic#58270
imotov
added a commit
that referenced
this pull request
Jun 29, 2020
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jun 29, 2020
The test didn't fail since the fix in elastic#58493. So, it's time to remove debug logging and close the issue. Closes elastic#58270
imotov
added a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes RestEqlCancellationIT more deterministic by adding an assertBusy for the
cancellation propagation. It also refactors the SearchBlockPlugin to block
after the field caps are received, which prevents the test to block on the
transport thread. Blocking on transport thread was preventing the cancellation
on disconnect from cancelling the task until after the block on the transport
thread was released.
Since I cannot reporduce this issue, I will leave the trace logging for now
and will remove it after observing this test for a while in CI.
Relates to #58270