fix cluster health rest api wait_for_no_initializing_shards bug #58379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
added
the
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Contributor
|
Related to #27489 |
Member
|
@elasticmachine update branch |
Member
|
@weizijun The fix looks good to me. Can you extract a utility method that parses a request and add a randomized unit test using FakeRestRequest? Thank you for your contribution. |
Contributor
|
@weizijun are you still interested in working on this? |
Contributor
Author
yeah, I will commit unit test as soon as possible |
Contributor
Author
Member
|
@elasticmachine update branch |
Member
|
@elasticmachine ok to test |
dnhatn
approved these changes
Jul 27, 2020
dnhatn
pushed a commit
that referenced
this pull request
Jul 27, 2020
dnhatn
pushed a commit
that referenced
this pull request
Jul 27, 2020
dnhatn
pushed a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RestClusterHealthAction, wait_for_no_initializing_shards's default param bug.