Save memory when parent and child are not on top #57892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the `parent` and `child` aggregation are not at the top level using the optimization from elastic#55873. Instead of wrapping all non-top-level `parent` and `child` aggregators we now handle being a child aggregator in the aggregator, specifically by adding recording which global ordinals show up in the parent and then checking if they match the child.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
nik9000
commented
Jun 9, 2020
| * to just those listed in ordsToCollect, but we don't have a data | ||
| * structure that maps a primitive long to a list of primitive | ||
| * longs. | ||
| */ |
Member
Author
There was a problem hiding this comment.
This is pretty much the algorithm that we used to use. It ain't perfect, but it gets the job done.
16 tasks
Member
Author
|
run elasticsearch-ci/packaging-sample-unix-docker |
talevy
approved these changes
Jun 10, 2020
| * to just those listed in ordsToCollect, but we don't have a data | ||
| * structure that maps a primitive long to a list of primitive | ||
| * longs. | ||
| */ |
Member
Author
|
Thanks @talevy ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jun 10, 2020
Reworks the `parent` and `child` aggregation are not at the top level using the optimization from elastic#55873. Instead of wrapping all non-top-level `parent` and `child` aggregators we now handle being a child aggregator in the aggregator, specifically by adding recording which global ordinals show up in the parent and then checking if they match the child.
nik9000
added a commit
that referenced
this pull request
Jun 10, 2020
Reworks the `parent` and `child` aggregation are not at the top level using the optimization from #55873. Instead of wrapping all non-top-level `parent` and `child` aggregators we now handle being a child aggregator in the aggregator, specifically by adding recording which global ordinals show up in the parent and then checking if they match the child.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 16, 2020
In elastic#57892 I broke *some* sub-aggregations inside of the `parent` and `child` aggregator, specifically any sub-aggregations that do work in the `postCollect` phase. This fixes it by delaying the post collect phase of aggs under `parent` and `child` until `beforeBuildingBuckets` because, well, we haven't done *any* collection until after that phase.
nik9000
added a commit
that referenced
this pull request
Oct 19, 2020
In #57892 I broke *some* sub-aggregations inside of the `parent` and `child` aggregator, specifically any sub-aggregations that do work in the `postCollect` phase. This fixes it by delaying the post collect phase of aggs under `parent` and `child` until `beforeBuildingBuckets` because, well, we haven't done *any* collection until after that phase.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 19, 2020
In elastic#57892 I broke *some* sub-aggregations inside of the `parent` and `child` aggregator, specifically any sub-aggregations that do work in the `postCollect` phase. This fixes it by delaying the post collect phase of aggs under `parent` and `child` until `beforeBuildingBuckets` because, well, we haven't done *any* collection until after that phase.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 19, 2020
In elastic#57892 I broke *some* sub-aggregations inside of the `parent` and `child` aggregator, specifically any sub-aggregations that do work in the `postCollect` phase. This fixes it by delaying the post collect phase of aggs under `parent` and `child` until `beforeBuildingBuckets` because, well, we haven't done *any* collection until after that phase.
nik9000
added a commit
that referenced
this pull request
Oct 19, 2020
In #57892 I broke *some* sub-aggregations inside of the `parent` and `child` aggregator, specifically any sub-aggregations that do work in the `postCollect` phase. This fixes it by delaying the post collect phase of aggs under `parent` and `child` until `beforeBuildingBuckets` because, well, we haven't done *any* collection until after that phase.
nik9000
added a commit
that referenced
this pull request
Oct 19, 2020
In #57892 I broke *some* sub-aggregations inside of the `parent` and `child` aggregator, specifically any sub-aggregations that do work in the `postCollect` phase. This fixes it by delaying the post collect phase of aggs under `parent` and `child` until `beforeBuildingBuckets` because, well, we haven't done *any* collection until after that phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the
parentandchildaggregation are not at the top levelusing the optimization from #55873. Instead of wrapping all
non-top-level
parentandchildaggregators we now handle being achild aggregator in the aggregator, specifically by adding recording
which global ordinals show up in the parent and then checking if they
match the child.