Drop rewriting in date_histogram #57836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `date_histogram` aggregation had an optimization where it'd rewrite `time_zones` who's offset from UTC is fixed across the entire index. This rewrite is no longer needed after elastic#56371 because we can tell that a time zone is fixed lower down in the aggregation. So this removes it.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
Member
Author
|
I'm benchmarking this now just to be sure it doesn't change performance. It shouldn't. |
This was referenced Jun 8, 2020
Member
Author
The performance doesn't change with this PR. |
not-napoleon
approved these changes
Jun 15, 2020
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. Love net negative code PRs :)
Contributor
|
|
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 1, 2020
The `date_histogram` aggregation had an optimization where it'd rewrite `time_zones` who's offset from UTC is fixed across the entire index. This rewrite is no longer needed after elastic#56371 because we can tell that a time zone is fixed lower down in the aggregation. So this removes it.
nik9000
added a commit
that referenced
this pull request
Jul 1, 2020
The `date_histogram` aggregation had an optimization where it'd rewrite `time_zones` who's offset from UTC is fixed across the entire index. This rewrite is no longer needed after #56371 because we can tell that a time zone is fixed lower down in the aggregation. So this removes it.
Member
Author
|
Thanks for the review @not-napoleon! These were hard-fought negative lines, that is for sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
date_histogramaggregation had an optimization where it'd rewritetime_zoneswho's offset from UTC is fixed across the entire index.This rewrite is no longer needed after #56371 because we can tell that a
time zone is fixed lower down in the aggregation. So this removes it.