Fix IndexRecoveryIT transient error test #57826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>test
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Tim-Brooks
added a commit
that referenced
this pull request
Jun 9, 2020
Currently it is possible for a transient network error to disrupt the start recovery request from the remote to source node. This disruption is racy with the recovery occurring on the source node. It is possible for the source node to finish and clear its recovery. When this occurs, the recovery cannot be reestablished and the "no two start" assertion is tripped. This commit fixes this issue by allowing two starts if the finalize request has been received. Fixes #57416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible for a transient network error to disrupt the
start recovery request from the remote to source node. This disruption
is racy with the recovery occurring on the source node. It is possible
for the source node to finish and clear its recovery. When this occurs,
the recovery cannot be reestablished and the "no two start" assertion
is tripped. This commit fixes this issue by allowing two starts if the
finalize request has been received.
Fixes #57416.