Include 'sourceUrl' column in dependencies report even when empty #57163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
mark-vieira
added a commit
that referenced
this pull request
May 26, 2020
…7163) Co-authored-by: Elastic Machine <[email protected]>
mark-vieira
added a commit
that referenced
this pull request
May 26, 2020
…7163) Co-authored-by: Elastic Machine <[email protected]>
mark-vieira
added a commit
that referenced
this pull request
May 26, 2020
…7163) Co-authored-by: Elastic Machine <[email protected]>
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #56642, we now include a
sourceURLcolumn in the generated report for dependencies whose source we need to redistribute. For release manager to properly parse this file, entries in the CSV file which omit this item still need the,delimiter. This PR changes the report generation to include the,delimiter for the column regardless of whether column contains data.See https://github.com/elastic/infra/pull/20555#issuecomment-634037543