Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented May 21, 2020

A task might not be canceled on disconnection if it is completed before the cancellation is started. We need to relax the assertion in this test.

Closes #56746

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. v8.0.0 v7.9.0 labels May 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Task Management)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 21, 2020
@dnhatn dnhatn requested a review from ywelsch May 25, 2020 12:53
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented May 25, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit d18c2ad into elastic:master May 25, 2020
@dnhatn dnhatn deleted the fix-tracking-task branch May 25, 2020 13:35
dnhatn added a commit that referenced this pull request May 25, 2020
A task might not be canceled on disconnection if it is completed before the cancellation
is started. We need to relax the assertion in this test.

Closes #56746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.9.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] TaskManagerTests#testTrackingChannelTask

4 participants