[DOCS] Reformat shingle token filter
#57040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Rewrites parameter documentation * Updates custom analyzer and filter examples * Adds anchor to `index.max_shingle_diff` index-level setting
jrodewig
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-search (:Search/Analysis) |
82 tasks
mayya-sharipova
approved these changes
May 21, 2020
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jrodewig Thanks! This looks very good to me.
| difference between `max_shingle_size` and `min_shingle_size`. | ||
| Add shingles, or word https://en.wikipedia.org/wiki/N-gram[n-grams], to a token | ||
| stream by concatenating adjacent tokens. By default, the `shingle` token filter | ||
| creates two-word shingles. |
Contributor
There was a problem hiding this comment.
should we also say "two-word shingles and unigrams"?
Contributor
Author
There was a problem hiding this comment.
Good catch. I've updated this to "outputs two-word shingles and unigrams".
Contributor
Author
|
Thanks @mayya-sharipova |
This was referenced May 21, 2020
jrodewig
added a commit
that referenced
this pull request
May 21, 2020
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Rewrites parameter documentation * Updates custom analyzer and filter examples * Adds anchor to `index.max_shingle_diff` index-level setting
jrodewig
added a commit
that referenced
this pull request
May 21, 2020
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Rewrites parameter documentation * Updates custom analyzer and filter examples * Adds anchor to `index.max_shingle_diff` index-level setting
jrodewig
added a commit
that referenced
this pull request
May 21, 2020
Changes: * Rewrites description and adds Lucene link * Adds analyze example * Rewrites parameter documentation * Updates custom analyzer and filter examples * Adds anchor to `index.max_shingle_diff` index-level setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
index.max_shingle_diffindex-level setting