Update date_histogram docs #56922
Merged
Update date_histogram docs #56922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it more clear that you can use `month` or `1M`. * Explain rounding rules * Consistently use "time zone" instead of "timezone". It looks like both are right but I see "time zone" much more. And the parameter in elasticsearch is `time_zone` so we may as well line up. Closes elastic#56760
nik9000
added
:Analytics/Aggregations
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Member
Author
|
Would anyone from @elastic/es-docs like to review this one? |
jrodewig
approved these changes
May 29, 2020
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
| The accepted units for fixed intervals are: | ||
|
|
||
| milliseconds (ms) :: | ||
| milliseconds (`ms`) :: |
Contributor
There was a problem hiding this comment.
Having an empty def feels weird to me. Maybe move the expanded word within the def?
`ms`::
Milliseconds
Would need to do this for all the definitions tho.
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
…sciidoc Co-authored-by: James Rodewig <[email protected]>
…sciidoc Co-authored-by: James Rodewig <[email protected]>
…sciidoc Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Member
Author
|
Thanks @jrodewig ! I committed your suggestions and added a few small things. I'll recheck the preview once it builds and merge. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
May 29, 2020
* Make it more clear that you can use `month` or `1M`. * Explain rounding rules * Consistently use "time zone" instead of "timezone". It looks like both are right but I see "time zone" much more. And the parameter in elasticsearch is `time_zone` so we may as well line up. Closes elastic#56760 Co-authored-by: James Rodewig <[email protected]>
nik9000
added a commit
that referenced
this pull request
May 29, 2020
* Make it more clear that you can use `month` or `1M`. * Explain rounding rules * Consistently use "time zone" instead of "timezone". It looks like both are right but I see "time zone" much more. And the parameter in elasticsearch is `time_zone` so we may as well line up. Closes #56760 Co-authored-by: James Rodewig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monthor1M.are right but I see "time zone" much more. And the parameter in
elasticsearch is
time_zoneso we may as well line up.Closes #56760