EnrichProcessorFactory should not throw NPE if missing metadata #55977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
jbaiera
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
elasticmachine
added
the
Team:Data Management
Contributor
I also encountered problems with the hash processor due to the same erroneous calls to its processor factory. I think we should address that so I opened #56019 for it. |
Member
Author
|
@elasticmachine run elasticsearch-ci/1 |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
May 14, 2020
…tic#55977) In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
May 14, 2020
…tic#55977) In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
jbaiera
added a commit
that referenced
this pull request
May 15, 2020
…) (#56793) In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
jbaiera
added a commit
that referenced
this pull request
May 15, 2020
…) (#56798) In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
May 15, 2020
…tic#55977) In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
jbaiera
added a commit
that referenced
this pull request
May 19, 2020
…) (#56843) In some cases the Enrich processor factory may be called before it is ready to create processors. While these calls are usually made in error, the response from the Enrich processor is an NPE which is almost always an unhelpful error when debugging an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the Enrich processor factory may be called before it is
ready to create processors. While these calls are usually made in error,
the response from the Enrich processor is an NPE which is almost always
an unhelpful error when debugging an issue.