Initial documentation for index templates V2 #55755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
debadair
suggested changes
Apr 24, 2020
Contributor
debadair
left a comment
debadair
left a comment
There was a problem hiding this comment.
Left a couple comments related to the build errror.
andreidan
approved these changes
Apr 27, 2020
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM thanks for adding the docs Lee. I've left 2 minor suggestions, but this is overall great
This commit adds the initial document for version two index templates. Since these are intended to be used in favor of V1 index templates, this re-uses the anchors for index templates to point to the V2 APIs, renaming the V1 template docs' anchors (this was a suggestion from the docs team). There is more documentation that can be written, but this is a start. Relates to elastic#53101
Co-Authored-By: debadair <[email protected]>
dakrone
force-pushed
the
itv2-documentation
branch
from
b294da6 to
2545a4c
Compare
debadair
approved these changes
Apr 28, 2020
Contributor
debadair
left a comment
debadair
left a comment
There was a problem hiding this comment.
Left a few minor comments/suggestions.
Co-Authored-By: debadair <[email protected]>
Member
Author
|
Thanks for the reviews all! |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Apr 28, 2020
This commit adds the initial document for version two index templates. Since these are intended to be used in favor of V1 index templates, this re-uses the anchors for index templates to point to the V2 APIs, renaming the V1 template docs' anchors (this was a suggestion from the docs team). There is more documentation that can be written, but this is a start. Relates to elastic#53101
dakrone
added a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the initial document for version two index templates. Since these are intended to
be used in favor of V1 index templates, this re-uses the anchors for index templates to point to the
V2 APIs, renaming the V1 template docs' anchors (this was a suggestion from the docs team).
There is more documentation that can be written, but this is a start.
Relates to #53101