Refactor GeoShape DocValues in spatial xpack #55492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors geo_shape doc values, fielddata, and utility classes from the single mapper package in x-pack spatial plugin to a package structure that is consistent with es server module.
nknize
added
>non-issue
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
talevy
approved these changes
Apr 20, 2020
|
|
||
| public class GeoShapeValuesSourceType implements Writeable, ValuesSourceType { | ||
|
|
||
| static GeoShapeValuesSourceType INSTANCE = new GeoShapeValuesSourceType(); |
Contributor
There was a problem hiding this comment.
in this case, should this be made private?
Contributor
|
I opened #55500, which needs to be backported into 7.x before this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
geo_shapedoc values field, fielddata, and utility classes from themapperpackage in x-packspatialplugin to a package structure that is consistent with esservermodule.