Test: MockScoreScript can be cacheable #55422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-elastic
added
the
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
jdconrad
approved these changes
Apr 18, 2020
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
Script side of this looks good to me. Thanks for fixing. Please have @mayya-sharipova review the changes to FunctionScoreQueryBuilderTests.
mayya-sharipova
approved these changes
Apr 20, 2020
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@stu-elastic Thanks for the change, nice for the tests to have the same logic as in the common case.
I have left a couple of small comments
...rc/test/java/org/elasticsearch/index/query/functionscore/FunctionScoreQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/elasticsearch/index/query/functionscore/FunctionScoreQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.