Enable decompression of response within LowLevelRestClient #55413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakky54
changed the title
Hakky54
changed the title
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
elasticmachine
added
the
Team:Data Management
Contributor
Author
|
@andreidan have you had a chance to look at this, anything you want done differently? |
andreidan
requested changes
May 14, 2020
qa/smoke-test-http/src/test/java/org/elasticsearch/http/HttpCompressionIT.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/elasticsearch/client/RestHighLevelClientTests.java
Show resolved
Hide resolved
Contributor
|
ok to test |
Contributor
Author
|
Awesome! Thank you @andreidan! |
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
May 15, 2020
…5413) Added support for decompression at LLRC and added integration test (cherry picked from commit 2621452) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
May 15, 2020
…56820) Added support for decompression at LLRC and added integration test (cherry picked from commit 2621452) Signed-off-by: Andrei Dan <[email protected]> Co-authored-by: Hakky54 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to enable the RestHighLevelClient and LowLevelRestClient to automatically handle an Elasticsearch response which has compressed content. It was already possible to do this with the low level client manually, see here AsyncElasticsearchCompressedRequest. Compression can enabled within a node configuration with the following property:
http.compression: trueCompression can be triggered by a request from a client. Therefor you also need to provide additional information within the header of the request to Elasticsearch if a client really wants to enable it. That is possible with the following RequestOptions:With these two properties Elasticsearch will return a gzip compressed response body. The RestHighLevelClient can send a request with the above request options but it couldn't handle the response yet. This feature request contains the option to handle a compressed response if it is compressed with gzip.
Initial changes for the RestHighLevelClient have been made within this pull request: #53533
Original feature requests: #53555 and #24349
This pull request is an improvement on the initial pull request. The LowLevelRestClient will get the responsibility to handle a compressed response and therefor this feature will also be supported within the RestHighLevelClient.