Fix test failure in FunctionScoreQueryBuilderTests.testCacheability #55343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rewrite more query builders to MatchNoneQueryBuilders now, which are always cacheable. We should make sure the tests expects this when the rewritten query is a MatchNoneQueryBuilder. Closes elastic#55331
cbuescher
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Member
Author
|
@jtibshirani this shouldn't happen very often since I think its triggered by changes in #55271, would you mind taking a look? |
jtibshirani
approved these changes
Apr 16, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Thanks @cbuescher for fixing this. It indeed looks like #55271 caused the failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rewrite more query builders to MatchNoneQueryBuilders now, which are always
cacheable. We should make sure the tests expects this when the rewritten query
is a MatchNoneQueryBuilder.
Closes #55331