[7.x] Add analytics plugin usage stats to _xpack/usage (#54911) #55162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds analytics plugin usage stats to _xpack/usage. Closes elastic#54847
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
polyfractal
approved these changes
Apr 14, 2020
Contributor
polyfractal
left a comment
polyfractal
left a comment
There was a problem hiding this comment.
Left another serialization question, but otherwise LGTM I think, given what we chatted about and what needs forward-porting to master.
Yay for having tests now so it doesn't go pear-shaped in the future :)
| if (out.getVersion().onOrAfter(Version.V_7_7_0)) { | ||
| out.writeVLong(counters.get(Item.BOXPLOT)); | ||
| } | ||
| out.writeZLong(counters.get(Item.CUMULATIVE_CARDINALITY)); |
Contributor
There was a problem hiding this comment.
Should this be a VLong not ZLong?
Contributor
Author
There was a problem hiding this comment.
It was ZLong in 7.6, got partially changed by mistake in 7.7. So, I am returning to back to the original serialization method and I will open a PR to fix it in 7.7. Good catch, thanks for reminding me!
Contributor
Author
There was a problem hiding this comment.
I opened #55183. Not sure if it will make it into 7.7.0 or not.
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 14, 2020
Fixes incorrect serialization of cumulativeCardinalityUsage Relates to elastic#55162
imotov
added a commit
that referenced
this pull request
Apr 15, 2020
Fixes incorrect serialization of cumulativeCardinalityUsage Relates to #55162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds analytics plugin usage stats to _xpack/usage.
Closes #54847
@nik9000, @polyfractal I will have to do some change to #54911 once this PR is merged to make it backward compatible. I discovered some issues during porting. Basically I will have to forward port these changes in AnalyticsStatsAction.java. Since there are significant changes in this backport I would love to get a review from one of you.