Rename some Docker projects for consistency #55150
Merged
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the :distribution:archives naming convention to some of the Docker sub-projects, so that we have a more consistent naming scheme.
pugnascotia
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
We've seen some exampples of Docker packaging tests failing sporadically when they try to clean up the temp directory, citing a not-empty directory. Ensure that any running container is removed before cleaning up the temp dir, in an effort to avoid this problem.
mark-vieira
reviewed
Apr 14, 2020
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Shouldn't this include changes to settings.gradle?
Contributor
Author
|
These projects aren't currently listed in |
pugnascotia
added a commit
that referenced
this pull request
Apr 14, 2020
Apply the :distribution:archives naming convention to some of the Docker sub-projects, so that we have a more consistent naming scheme. Also, we've seen some examples of Docker packaging tests failing sporadically when they try to clean up the temp directory, citing a not-empty directory. Ensure that any running container is removed before cleaning up the temp dir, in an effort to avoid this problem.
pugnascotia
added a commit
that referenced
this pull request
Apr 14, 2020
Apply the :distribution:archives naming convention to some of the Docker sub-projects, so that we have a more consistent naming scheme. Also, we've seen some examples of Docker packaging tests failing sporadically when they try to clean up the temp directory, citing a not-empty directory. Ensure that any running container is removed before cleaning up the temp dir, in an effort to avoid this problem.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the
:distribution:archivesnaming convention to some of the Dockersub-projects, so that we have a more consistent naming scheme.
This came from a suggestion in #55073.