ILM fix retry delete action test #54809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidan
added
>test
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
Asserting on the failed_step field from the explainAPI can produce flakiness because the ILM state is moved back and forth between the (failing) step and the ERROR step (as the workflow is retry, fail then move to ERROR step, move back to the (failing) step, retry, fail, etc) and the failed_step information is only available whilst in the ERROR state.
A read-only index could not be deleted in the wipeCluster phase and caused these failures
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 7, 2020
Asserting on the failed_step field from the explainAPI can produce flakiness because the ILM state is moved back and forth between the (failing) step and the ERROR step (as the workflow is retry, fail then move to ERROR step, move back to the (failing) step, retry, fail, etc) and the failed_step information is only available whilst in the ERROR state. Unmute other tests as they were collateral failures A read-only index could not be deleted in the wipeCluster phase and caused these failures (cherry picked from commit 99a6d57) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Apr 7, 2020
Asserting on the failed_step field from the explainAPI can produce flakiness because the ILM state is moved back and forth between the (failing) step and the ERROR step (as the workflow is retry, fail then move to ERROR step, move back to the (failing) step, retry, fail, etc) and the failed_step information is only available whilst in the ERROR state. Unmute other tests as they were collateral failures A read-only index could not be deleted in the wipeCluster phase and caused these failures (cherry picked from commit 99a6d57) Signed-off-by: Andrei Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use just the
read_onlysetting to induce delete action failures, as opposed to a mix ofread_only_allow_deleteandread_only.Fixes #53738