Fix updating include_in_parent/include_in_root of nested field. #54386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyHunt66
added
the
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
dakrone
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
jtibshirani
reviewed
Mar 30, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Thanks @gaobinlong for the contribution! I left a couple comments.
server/src/main/java/org/elasticsearch/index/mapper/ObjectMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/ObjectMapper.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/mapper/NestedObjectMapperTests.java
Outdated
Show resolved
Hide resolved
jtibshirani
reviewed
Apr 9, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
The new structure looks good, I have one last comment about the test. I'll kick off CI to check that all tests pass.
server/src/test/java/org/elasticsearch/index/mapper/NestedObjectMapperTests.java
Show resolved
Hide resolved
Contributor
|
@elasticmachine test this please |
Contributor
Author
|
@jtibshirani, I have pushed a new commit, can you take a look at the change? |
jtibshirani
reviewed
Apr 10, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
One last comment, thanks for your patience on this review.
server/src/test/java/org/elasticsearch/index/mapper/NestedObjectMapperTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine test this please |
jtibshirani
approved these changes
Apr 16, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Looks good to me! I will merge and backport to 7.x, along with a note in the migration docs.
jtibshirani
pushed a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Apr 16, 2020
elastic#54386) The main changes are: 1. Throw an error when updating `include_in_parent` or `include_in_root` attribute of nested field dynamically by the PUT mapping API. 2. Add a test for the change. Closes elastic#53792
jtibshirani
changed the title
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53792
The main changes are:
include_in_parentorinclude_in_rootattribute of nested field dynamically by the PUT mapping API.