Delay warning about missing x-pack #54265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when monitoring is enabled in a freshly-installed cluster, the non-master nodes log a warning message indicating that master may not have x-pack installed. The message is often printed even when the master does have x-pack installed but takes some time to setup the local exporter for monitoring. This commit adds the local exporter setting `wait_master.timeout` which defaults to 30 seconds. The setting configures the time that the non-master nodes should wait for master to setup monitoring. After the time elapses, they log a message to the user about possible missing x-pack installation on master. The logging of this warning was moved from `resolveBulk()` to `openBulk()` since `resolveBulk()` is called only on cluster updates and the message might not be logged until a new cluster update occurs. Closes elastic#40898
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
Contributor
|
@elasticmachine ok to test |
Contributor
|
@elasticmachine update branch |
Contributor
|
@elasticmachine update branch |
danhermann
reviewed
Apr 10, 2020
Contributor
danhermann
left a comment
danhermann
left a comment
There was a problem hiding this comment.
@mariaral, thanks for making this change. I'm going to look it over in the next few days and see if we can get it merged.
Contributor
|
@elasticmachine update branch |
Contributor
|
@mariaral, thanks for your contribution here. I'll get it backported for the appropriate releases. |
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
May 4, 2020
Currently, when monitoring is enabled in a freshly-installed cluster, the non-master nodes log a warning message indicating that master may not have x-pack installed. The message is often printed even when the master does have x-pack installed but takes some time to setup the local exporter for monitoring. This commit adds the local exporter setting `wait_master.timeout` which defaults to 30 seconds. The setting configures the time that the non-master nodes should wait for master to setup monitoring. After the time elapses, they log a message to the user about possible missing x-pack installation on master. The logging of this warning was moved from `resolveBulk()` to `openBulk()` since `resolveBulk()` is called only on cluster updates and the message might not be logged until a new cluster update occurs. Closes elastic#40898 Co-authored-by: Elastic Machine <[email protected]>
danhermann
added a commit
that referenced
this pull request
May 4, 2020
* Delay warning about missing x-pack (#54265) Currently, when monitoring is enabled in a freshly-installed cluster, the non-master nodes log a warning message indicating that master may not have x-pack installed. The message is often printed even when the master does have x-pack installed but takes some time to setup the local exporter for monitoring. This commit adds the local exporter setting `wait_master.timeout` which defaults to 30 seconds. The setting configures the time that the non-master nodes should wait for master to setup monitoring. After the time elapses, they log a message to the user about possible missing x-pack installation on master. The logging of this warning was moved from `resolveBulk()` to `openBulk()` since `resolveBulk()` is called only on cluster updates and the message might not be logged until a new cluster update occurs. Closes #40898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when monitoring is enabled in a freshly-installed cluster,
the non-master nodes log a warning message indicating that master may
not have x-pack installed. The message is often printed even when the
master does have x-pack installed but takes some time to setup the local
exporter for monitoring. This commit adds the local exporter setting
wait_master.timeoutwhich defaults to 30 seconds. The settingconfigures the time that the non-master nodes should wait for master to
setup monitoring. After the time elapses, they log a message to the user
about possible missing x-pack installation on master.
The logging of this warning was moved from
resolveBulk()toopenBulk()sinceresolveBulk()is called only on cluster updates andthe message might not be logged until a new cluster update occurs.
Closes #40898