Revert "Use Azure Bulk Deletes in Azure Repository (#53919)" #54089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 23cccf0. Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet. Closes elastic#54080
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
Author
|
@tlrx see #54080 (comment) :( SAS token auth is still broken (tried adding logic to generate service level SAS in the code but those are broken as well so no point in that for now). Gnarf |
tlrx
approved these changes
Mar 24, 2020
Contributor
Author
|
Thanks Tanguy, we'll get this to work one day :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 24, 2020
…lastic#54089) This reverts commit 23cccf0. Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet. Closes elastic#54080
original-brownbear
added a commit
that referenced
this pull request
Mar 25, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 26, 2020
…lastic#54089) This reverts commit 23cccf0. Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet. Closes elastic#54080
original-brownbear
added a commit
that referenced
this pull request
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.
Closes #54080