Skip to content

Conversation

@andyb-elastic
Copy link
Contributor

This adds tests for supported ValuesSourceTypes, unmapped fields,
scripting, and the missing param.

Also changes the supported type tests to catch AssertionError, which is
what string stats produces on some unsupported field types. And when
this test fails it now lists the original exception/assertion error as a
cause

This adds tests for supported ValuesSourceTypes, unmapped fields,
scripting, and the missing param.

Also changes the supported type tests to catch AssertionError, which is
what string stats produces on some unsupported field types. And when
this test fails it now lists the original exception/assertion error as a
cause
@andyb-elastic andyb-elastic added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.0.0 labels Mar 23, 2020
@andyb-elastic andyb-elastic requested a review from csoulios March 23, 2020 22:10
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@andyb-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix-unix please

Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyb-elastic andyb-elastic merged commit ef27430 into elastic:master Mar 24, 2020
@andyb-elastic
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants