Skip to content

Add supported-type tests to Average aggregation #54011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Add supported-type tests to Average aggregation #54011

merged 1 commit into from
Mar 24, 2020

Conversation

@csoulios
Copy link
Contributor

@csoulios csoulios commented Mar 23, 2020 •
edited
Loading

PR that adds tests for supported ValuesSourceTypes for the AvgAggregator

@csoulios csoulios added the :Analytics/Aggregations Aggregations label Mar 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2020

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@csoulios csoulios added >test Issues or PRs that are addressing/adding tests v8.0.0 labels Mar 23, 2020
@csoulios csoulios requested a review from andyb-elastic March 23, 2020 18:42
@polyfractal polyfractal mentioned this pull request Mar 23, 2020
Open
26 tasks
polyfractal
polyfractal approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@polyfractal polyfractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andyb-elastic
andyb-elastic approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@andyb-elastic andyb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csoulios csoulios merged commit f9526f9 into elastic:master Mar 24, 2020
@csoulios csoulios deleted the avg-agg-tests branch March 24, 2020 06:42
csoulios added a commit to csoulios/elasticsearch that referenced this pull request Apr 16, 2020
@csoulios
Add supported-type tests to avg aggregation (elastic#54011)
4e975e3
@csoulios csoulios mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@polyfractal polyfractal polyfractal approved these changes

@andyb-elastic andyb-elastic andyb-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csoulios @elasticmachine @polyfractal @andyb-elastic @jakelandis