Scripting: stats per context in nodes stats #54008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-elastic
added
>enhancement
WIP
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
…152-painless-limit-per-context__06__stats-api
williamrandolph
suggested changes
Mar 24, 2020
Contributor
williamrandolph
left a comment
williamrandolph
left a comment
There was a problem hiding this comment.
Looks good. One question, one small change request.
server/src/main/java/org/elasticsearch/action/admin/cluster/node/stats/NodeStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/ScriptCacheStats.java
Outdated
Show resolved
Hide resolved
…152-painless-limit-per-context__06__stats-api
…152-painless-limit-per-context__06__stats-api
…152-painless-limit-per-context__06__stats-api
…152-painless-limit-per-context__06__stats-api
williamrandolph
approved these changes
Mar 26, 2020
Contributor
williamrandolph
left a comment
williamrandolph
left a comment
There was a problem hiding this comment.
This looks good to me, though I haven't dug into how the tests are set up.
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Mar 26, 2020
Adds script cache stats to `_node/stats`.
If using the general cache:
```
"script_cache": {
"sum": {
"compilations": 12,
"cache_evictions": 9,
"compilation_limit_triggered": 5
}
}
```
If using context caches:
```
"script_cache": {
"sum": {
"compilations": 13,
"cache_evictions": 9,
"compilation_limit_triggered": 5
},
"contexts": [
{
"context": "aggregation_selector",
"compilations": 8,
"cache_evictions": 6,
"compilation_limit_triggered": 3
},
{
"context": "aggs",
"compilations": 5,
"cache_evictions": 3,
"compilation_limit_triggered": 2
},
```
Refs: elastic#50152
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 27, 2020
In elastic#54008 we used v7.8 here but never backported to 7.x. now that 7.x has moved to 7.8 BwC serialization is broken => adjusting the constant here until we backport.
original-brownbear
added a commit
that referenced
this pull request
Mar 27, 2020
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Mar 27, 2020
Adds script cache stats to `_node/stats`.
If using the general cache:
```
"script_cache": {
"sum": {
"compilations": 12,
"cache_evictions": 9,
"compilation_limit_triggered": 5
}
}
```
If using context caches:
```
"script_cache": {
"sum": {
"compilations": 13,
"cache_evictions": 9,
"compilation_limit_triggered": 5
},
"contexts": [
{
"context": "aggregation_selector",
"compilations": 8,
"cache_evictions": 6,
"compilation_limit_triggered": 3
},
{
"context": "aggs",
"compilations": 5,
"cache_evictions": 3,
"compilation_limit_triggered": 2
},
```
Refs: elastic#50152
stu-elastic
added a commit
that referenced
this pull request
Mar 27, 2020
Adds script cache stats to `_node/stats`.
If using the general cache:
```
"script_cache": {
"sum": {
"compilations": 12,
"cache_evictions": 9,
"compilation_limit_triggered": 5
}
}
```
If using context caches:
```
"script_cache": {
"sum": {
"compilations": 13,
"cache_evictions": 9,
"compilation_limit_triggered": 5
},
"contexts": [
{
"context": "aggregation_selector",
"compilations": 8,
"cache_evictions": 6,
"compilation_limit_triggered": 3
},
{
"context": "aggs",
"compilations": 5,
"cache_evictions": 3,
"compilation_limit_triggered": 2
},
```
Backport of: 32f46f2
Refs: #50152
Contributor
Author
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds script cache stats to
_node/stats.If using the general cache:
If using context caches:
Refs: #50152