Clean up IndexTemplateMetaData xcontent serialization #54003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
Contributor
Author
|
This should make it easier to detect when a template has multiple mapping types, and optionally throw exceptions that will cause a master node to fail to start up. We could also plausibly backport it to 7.x as it's a nice general cleanup, but there's no rush to make feature freeze for 7.7 |
andreidan
approved these changes
Mar 24, 2020
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, nice refactoring @romseygeek
romseygeek
added a commit
that referenced
this pull request
Mar 24, 2020
This reverts commit 04c21af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexTemplateMetaData x-content serialization is a bit confused and trappy at the
moment, with multiple static methods on the Builder object which may or may not
emit the template name and/or mapping types. This commit consolidates everything
into a single
toXContent()method on the base class, with different options passedthrough as
ToXContent.Params. Deserialization is converted to use anObjectParser,taking the template name as a context.