[ML] No refresh on indexing DFA stats #53977
Merged
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
benwtrent
approved these changes
Mar 23, 2020
Member
There was a problem hiding this comment.
Suggested change
| LOGGER.debug("[{}] Refreshing indices {}", jobId, Arrays.toString(refreshRequest.indices())); | |
| LOGGER.debug(() -> new ParameterizedMessage("[{}] Refreshing indices {}", jobId, Arrays.toString(refreshRequest.indices()))); |
I think the string is created eagerly. This is not strictly necessary unless the logging level is debug.
This is a minor thing as most of our logging does not take this into account.
Contributor
There was a problem hiding this comment.
Would it make sense to also refresh dest index in this method?
Contributor
Author
There was a problem hiding this comment.
We need to use the config's headers to refresh the dest index which is why I kept it separate.
Contributor
There was a problem hiding this comment.
Right, thanks for explanation.
When we index data frame analytics stats docs we do not need to refresh immediately.
dimitris-athanasiou
force-pushed
the
no-refresh-on-indexing-dfa-stats
branch
from
13e6010 to
5ea3e2d
Compare
przemekwitek
approved these changes
Mar 24, 2020
Contributor
There was a problem hiding this comment.
Right, thanks for explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we index data frame analytics stats docs we do not
need to refresh immediately.