Cluster state and CRUD operations for data streams #53877
Conversation
danhermann
added
>non-issue
v8.0.0
v7.7.0
:Data Management/Data streams
|
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamMetadata.java
Outdated
Show resolved
Hide resolved
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Looks good. I left a number of comments.
server/src/main/java/org/elasticsearch/indices/DataStreamMissingException.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/action/admin/indices/datastream/CreateDataStreamAction.java
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/indices.data_stream/10_basic.yml
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamMetadataTests.java
Show resolved
Hide resolved
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Looking good. Left some test comments.
.../src/main/java/org/elasticsearch/action/admin/indices/datastream/CreateDataStreamAction.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/ToAndFromJsonMetaDataTests.java
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/action/admin/indices/datastream/CreateDataStreamAction.java
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/action/admin/indices/datastream/DeleteDataStreamAction.java
Show resolved
Hide resolved
| } | ||
|
|
||
| static List<DataStream> getDataStreams(ClusterState clusterState, Request request) { | ||
| Map<String, DataStream> dataStreams = clusterState.metaData().dataStreams(); |
There was a problem hiding this comment.
unit test?
Also I think this should throw a resource not found exception if a specific data stream doesn't exist?
There was a problem hiding this comment.
It seems there are different existing behaviors when attempting to retrieve a specific resource that does not exist. E.g., aliases and indices return a 404 and index templates and ingest pipelines return an empty list. I don't if those are intentional behavioral differences, but I can certainly return a 404 if that's appropriate for data streams.
There was a problem hiding this comment.
I think that returning a 404 in case of requesting a specific data stream is appropriate.
|
@elasticmachine update branch |
|
@elasticmachine update branch |
4 participants
Adds data streams to cluster state and implements their create, delete, and get operations.
Relates to #53100.