Remove support for delaying state recovery pending master #53845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: David Turner <[email protected]>
DaveCTurner
added
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
Contributor
|
@elasticmachine test this please |
DaveCTurner
reviewed
Mar 20, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks @ShawnLi1014. Before I dive into the code in detail, there's a couple of points for the docs:
- would you document this change in docs/reference/migration/migrate_8_0/settings.asciidoc since it's a breaking change? Note the settings that were removed and name the settings that users should use instead.
- the docs themselves deserve a bit more of an overhaul, since there's now only one
expected_setting and onerecover_after_. I think we can explain what they do a bit more clearly now that we don't have to account for people using some combination of all the different settings.
You can see a preview of the docs here: http://elasticsearch_53845.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/modules-gateway.html which hopefully helps.
I think an example would be useful too. See the end of docs/reference/setup/important-settings/discovery-settings.asciidoc for an example of the syntax for a YAML example with callouts to explain each part. Would you add an example?
I'll help with the details of the docs at a later date if needed.
Contributor
|
Also note the check style failure from CI: |
Contributor
|
@ShawnLi1014 how are you getting on with addressing the review comments? |
Contributor
Author
Sry for the delay. I have committed the changes, please take a look. If there's anything need to be improved please let me know |
rjernst
added
the
Team:Distributed (Obsolete)
Contributor
|
@elasticmachine ok to test |
Contributor
|
Thanks for your patience here @ShawnLi1014. I've brought this branch up to date with recent changes in |
Contributor
|
@ShawnLi1014 are you still interested in working on this? |
This commit removes the following deprecated settings in v8: - `gateway.expected_nodes` - `gateway.expected_master_nodes` - `gateway.recover_after_nodes` - `gateway.recover_after_master_nodes` Co-authored-by: ShawnLi1014 <[email protected]>
Contributor
|
I opened #68316 for the failure. @elasticmachine please run elasticsearch-ci/1 |
80 tasks
jrodewig
added a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77951) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77952) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77953) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77958) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77954) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77956) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77955) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77957) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
jrodewig
added a commit
that referenced
this pull request
Sep 16, 2021
…) (#77959) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following settings are deprecated:
gateway.expected_nodesgateway.expected_master_nodesgateway.recover_after_nodesgateway.recover_after_master_nodesThis pull request removed these settings.
Closes #51806